-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Angular 8 - web-animations-js #14826
Comments
@yodi-n the dependency uri is incorrect it should be The main reason why it's not an NPM package is that this is a temporary solution which wouldn't ideally be published as a separate NPM package, and also @angular doesn't own That being said we are still waiting on the Some worksarounds would be;
Lets continue tracking this in: #14518 |
Also of note, is that the project may not actually need the polyfill anymore. It is only needed by Angular if the project is using the AnimationBuilder class. Declarative animations do not require the polyfill. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
After updating our projects form Angular 7 to Angular 8, our Jenkins was not able run npm install due to this line in the package.json file
"web-animations-js": "angular/web-animations-js#release_pr208"
The thing is that our Jenkins is behind a corporate proxy that does not allow calls to github.com
Command (mark with an
x
)Is this a regression?
Yes, this did not happen with previous versions of Angular
Description
When running npm ci, our Jenkins is not able to get the web-animation-js dependency on the angular github for of the original project.
🔬 Minimal Reproduction
I don't understand why the Angular team did not uploaded this dependency under @angular/web-animation-js or something instead of just pointing to a PR of a for of the original project.
I realise this is not really a bug since it is a feature of NPM to be able to fetch dependencies directly on github, but it is the first time since I'm using Angular that this happens.
The text was updated successfully, but these errors were encountered: