Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add utility functions for route generation #1330

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

emma-mens
Copy link
Contributor

@emma-mens emma-mens commented Jul 12, 2016

'route-utils.ts' provides utility functions to be used in generating routes
'blueprints/routes/*' creates a 'routes.ts' file when the newroutes command is
run and 'route.ts' doesn't exit

@emma-mens emma-mens changed the title Newroute feat: add utility functions for route generation Jul 12, 2016
@emma-mens emma-mens force-pushed the newroute branch 2 times, most recently from deda112 to aef97c6 Compare July 20, 2016 21:16
@emma-mens emma-mens force-pushed the newroute branch 11 times, most recently from 90315fb to 0ea756f Compare July 26, 2016 22:34
@emma-mens emma-mens force-pushed the newroute branch 3 times, most recently from fbc7958 to 2b05c22 Compare July 28, 2016 23:10
import * as ts from 'typescript';
import * as fs from 'fs';
import * as path from 'path';
import * as edit from './change';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import {Changes}, unless there is a problem importing the symbol directly?

@emma-mens emma-mens force-pushed the newroute branch 5 times, most recently from fcb5ca8 to 842f993 Compare August 4, 2016 23:54
});

let rootNode = ts.createSourceFile(mainFile, fs.readFileSync(mainFile).toString(),
ts.ScriptTarget.ES6, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align.

@emma-mens emma-mens force-pushed the newroute branch 2 times, most recently from 1c46040 to 7025d5d Compare August 9, 2016 17:20
@hansl
Copy link
Contributor

hansl commented Aug 9, 2016

Is this ready to be committed? @alxhub do you have time to look at this?

'route-utils.ts' provides utility functions to be used in generating routes
@hansl hansl merged commit 4fd8e9c into angular:master Aug 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants