Error in SSR if server build with `bundleDependencies=all` #12273

clark0x · 2018-09-14T15:21:59Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an `x`)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [x] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.2.1
Node: 8.11.2
OS: darwin x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package Version

@angular-devkit/architect 0.8.1
@angular-devkit/build-angular 0.8.1
@angular-devkit/build-ng-packagr 0.8.1
@angular-devkit/build-optimizer 0.8.1
@angular-devkit/build-webpack 0.8.1
@angular-devkit/core 0.8.1
@angular-devkit/schematics 0.8.1
@angular/cdk 6.4.7
@angular/cli 6.2.1
@angular/flex-layout 6.0.0-beta.18
@angular/material 6.4.7
@angular/pwa 0.8.1
@ngtools/json-schema 1.1.0
@ngtools/webpack 6.2.1
@schematics/angular 0.8.1
@schematics/update 0.8.1
ng-packagr 4.1.1
rxjs 6.3.2
typescript 2.9.2
webpack 4.18.0

Repro steps

I use universal-starter, only change one line in angular.json:

"server": {
  "configurations": {
    "production": {
      "bundleDependencies": "all", <= added
      ...

$ git clone -b issue-error-with-bundleDependencies  [email protected]:clarkorz/universal-starter.git
$ cd universal-starter
$ yarn install
$ yarn build:ssr
$ yarn serve:ssr

Access http://localhost:4000 in browser.

The log given by the failure

Error: No NgModule metadata found for '[object Object]'.
    at NgModuleResolver.resolve (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:11962:27)
    at CompileMetadataResolver.getNgModuleMetadata (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:10604:47)
    at JitCompiler._loadModules (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23914:55)
    at JitCompiler._compileModuleAndComponents (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23895:40)
    at JitCompiler.compileModuleAsync (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/compiler/bundles/compiler.umd.js:23855:41)
    at CompilerImpl.compileModuleAsync (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js:195:35)
    at /Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:95:25
    at new ZoneAwarePromise (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/zone.js/dist/zone-node.js:891:29)
    at getFactory (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:81:12)
    at View.engine (/Users/wangshuo/Documents/GitHub/universal-starter/node_modules/@nguniversal/express-engine/bundles/express-engine.umd.js:60:13)

Desired functionality

bundleDependencies=all should work as same as bundleDependencies=none.

Mention any other details that might be useful

No.

The text was updated successfully, but these errors were encountered:

alan-agius4 · 2018-09-14T16:18:37Z

I think what's happening here, is that you have 2 instances of Angular providers running in parallel.

One in the server.bundle javascript files since it's being bundled and another which is being required from the server.js

//cc @vikerman

naveedahmed1 · 2018-09-19T19:20:00Z

Is it related to #8616 ?

hansl · 2018-09-28T16:09:31Z

It seems it is a duplicate of #8616.

vikerman · 2018-09-28T18:04:34Z

Have a repro. First need to figure out why JitCompiler is getting involved at all since we pass in the NgFactory to the express engine.

NateWarner · 2018-12-27T23:38:03Z

@vikerman Any update on this issue or workaround? I'm running into it with latest Angular CLI and this seems to be a hard blocker atm.

ErazerBrecht · 2019-01-25T09:29:36Z

I'm running against the same problems.
The workaround of #8616 also didn't seem to work (optimization: false)

mgechev · 2019-01-25T18:10:49Z

@vikerman @MarkPieszak, would you have a look?

naveedahmed1 · 2019-01-29T12:33:10Z

@mgechev its related to #8616 which was opened on Nov 23, 2017 but still not fixed.

vikerman · 2019-01-31T07:04:23Z

On it (again). Investigating the root cause.

ErazerBrecht · 2019-04-07T20:49:29Z

@vikerman
Hello,
I don't want to be annoying but did you make any progress?

I'm at a point where we really need it. So my plan was to bundle it myself with webpack.
So I could avoid the bundleDependencies=all. But ofcourse this also causes the same problem.

No NgModule metadata found for '[object Object]'.

I tried to debug it a bit, but I'm not knowable of the internal workings of Angular itself.
So I have no clue where to start. And after searching the net I stumbled on this issue 'again'.

ErazerBrecht · 2019-04-08T05:53:50Z

@vikerman
I tried to debug some stuff.
And I'm probably already going to say stuff you already know.

https://github.com/angular/universal/blob/83f659777a1f7914c357d5c0eb72705b04dc94ea/modules/express-engine/src/main.ts#L118

When using bundleDependencies=all this check returns false.
I have no idea why. When enabling or disabling bundleDependencies the result of
Object.getPrototypeOf(moduleOrFactory) seemed to be the 'same'.

I removed the check locally to see if it would magically work. But it seems we then have a whole bunch of other errors. So I assume the generated webpack bundle is 'wrong'. My knowledge of webpack is also to limited to say something useful (I tried to compare the bundles, but I couldn't really make much of it)

vikerman · 2019-05-24T04:04:31Z

We were ending up with two copies of Angular due to the bundling setup we have for express-engine. We think we finally have a solution(See PR above) and turning on bundleDependencies on by default for version 8.0 of @nguniversal/express-engine. Still end up with a dist/server.js and dist/server/main.js (and dist/server/*.js for dynamic import based lazy routes) - But that's still lot better than shipping entire node_modules.

vikerman · 2019-05-24T04:05:52Z

@ErazerBrecht - We think we have a solution for version 8.0.

ErazerBrecht · 2019-05-25T11:49:58Z

@vikerman
I saw the PR ;)
I'm very exited to test it out.

Thx for update!
Enjoy your weekend!

everflux · 2019-08-02T12:17:37Z

Was this fixed with 8.2 ?

vikerman · 2019-08-13T13:32:29Z

The new 8.x versions of @nguniversal/express-engine schematics creates a setup which avoid this issue.

If you are upgrading to 8.x version please follow https://github.com/angular/universal/blob/master/docs/v8-upgrade-guide.md

naveedahmed1 · 2019-08-13T13:48:39Z

Would it work with ASP. Net/.Net Core? Can you please add instructions for that in readme docs?

alan-agius4 · 2019-09-02T18:10:36Z

@naveedahmed1, yeah this should also work for the .net implementation. You’d need to export ngAspnetCoreEngine from main.server.ts.

Closing this issue as it should be solved as per @vikerman’s comment.

If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.

angular-automatic-lock-bot · 2019-10-03T08:01:47Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely workaround1: obvious area: @angular-devkit/build-angular labels Sep 14, 2018

ngbot bot added this to the needsTriage milestone Sep 14, 2018

alan-agius4 removed the workaround1: obvious label Sep 14, 2018

This was referenced Sep 18, 2018

build: remove webpack process and replace with tsc angular/universal-starter#626

Merged

Error: No NgModule metadata found for '[object Object]' angular/universal#1067

Closed

filipesilva added type: bug/fix severity3: broken labels Sep 24, 2018

ngbot bot modified the milestones: needsTriage, Backlog Sep 24, 2018

hansl assigned vikerman Sep 28, 2018

alan-agius4 mentioned this issue Jan 3, 2019

App-shell devkit builder doesn't support ES6 imports #13181

Closed

vikerman mentioned this issue May 24, 2019

fix(express-engine): add bundleDependencies and lazy-loading fixes angular/universal#1167

Merged

naveedahmed1 mentioned this issue Sep 2, 2019

Fix for 2 years old issue StaticInjectorError error when --bundle-dependencies=all #15498

Closed

alan-agius4 closed this as completed Sep 2, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error in SSR if server build with `bundleDependencies=all` #12273

Error in SSR if server build with `bundleDependencies=all` #12273

clark0x commented Sep 14, 2018 •

edited

Loading

alan-agius4 commented Sep 14, 2018

naveedahmed1 commented Sep 19, 2018

hansl commented Sep 28, 2018

vikerman commented Sep 28, 2018 •

edited

Loading

NateWarner commented Dec 27, 2018

ErazerBrecht commented Jan 25, 2019

mgechev commented Jan 25, 2019

naveedahmed1 commented Jan 29, 2019

vikerman commented Jan 31, 2019 •

edited

Loading

ErazerBrecht commented Apr 7, 2019 •

edited

Loading

ErazerBrecht commented Apr 8, 2019

vikerman commented May 24, 2019 •

edited

Loading

vikerman commented May 24, 2019

ErazerBrecht commented May 25, 2019

everflux commented Aug 2, 2019

vikerman commented Aug 13, 2019

naveedahmed1 commented Aug 13, 2019

alan-agius4 commented Sep 2, 2019

angular-automatic-lock-bot bot commented Oct 3, 2019

Error in SSR if server build with bundleDependencies=all #12273

Error in SSR if server build with bundleDependencies=all #12273

Comments

clark0x commented Sep 14, 2018 • edited Loading

Bug Report or Feature Request (mark with an x)

Command (mark with an x)

Versions

Package Version

Repro steps

The log given by the failure

Desired functionality

Mention any other details that might be useful

alan-agius4 commented Sep 14, 2018

naveedahmed1 commented Sep 19, 2018

hansl commented Sep 28, 2018

vikerman commented Sep 28, 2018 • edited Loading

NateWarner commented Dec 27, 2018

ErazerBrecht commented Jan 25, 2019

mgechev commented Jan 25, 2019

naveedahmed1 commented Jan 29, 2019

vikerman commented Jan 31, 2019 • edited Loading

ErazerBrecht commented Apr 7, 2019 • edited Loading

ErazerBrecht commented Apr 8, 2019

vikerman commented May 24, 2019 • edited Loading

vikerman commented May 24, 2019

ErazerBrecht commented May 25, 2019

everflux commented Aug 2, 2019

vikerman commented Aug 13, 2019

naveedahmed1 commented Aug 13, 2019

alan-agius4 commented Sep 2, 2019

angular-automatic-lock-bot bot commented Oct 3, 2019

Error in SSR if server build with `bundleDependencies=all` #12273

Error in SSR if server build with `bundleDependencies=all` #12273

clark0x commented Sep 14, 2018 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

Command (mark with an `x`)

vikerman commented Sep 28, 2018 •

edited

Loading

vikerman commented Jan 31, 2019 •

edited

Loading

ErazerBrecht commented Apr 7, 2019 •

edited

Loading

vikerman commented May 24, 2019 •

edited

Loading