fix(@ngtools/webpack): use tsconfig declaration flag to report decl e…

…rrors (#3499)
angular · Dec 9, 2016 · c46de15 · c46de15
1 parent 87b93e1
commit c46de15
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/@ngtools/webpack/src/refactor.ts b/packages/@ngtools/webpack/src/refactor.ts
@@ -48,14 +48,20 @@ export class TypeScriptFileRefactor {
     this._sourceString = new MagicString(this._sourceText);
   }
 
+  /**
+   * Collates the diagnostic messages for the current source file
+   */
   getDiagnostics(): ts.Diagnostic[] {
     if (!this._program) {
       return [];
     }
-
-    return this._program.getSyntacticDiagnostics(this._sourceFile)
-      .concat(this._program.getSemanticDiagnostics(this._sourceFile))
-      .concat(this._program.getDeclarationDiagnostics(this._sourceFile));
+    let diagnostics: ts.Diagnostic[] = this._program.getSyntacticDiagnostics(this._sourceFile)
+                              .concat(this._program.getSemanticDiagnostics(this._sourceFile));
+    // only concat the declaration diagnostics if the tsconfig config sets it to true.
+    if (this._program.getCompilerOptions().declaration == true) {
+      diagnostics = diagnostics.concat(this._program.getDeclarationDiagnostics(this._sourceFile));
+    }
+    return diagnostics;
   }
 
   /**