Skip to content

Commit

Permalink
fix(@angular/cli): add missing webpack-sources dep
Browse files Browse the repository at this point in the history
`license-webpack-plugin` has a peer dependency on `webpack-sources` that was being satisfied via hoisting.

Fix #8075
  • Loading branch information
filipesilva committed Oct 18, 2017
1 parent 3a14856 commit 2a3490f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"webpack-dev-middleware": "~1.12.0",
"webpack-dev-server": "~2.7.1",
"webpack-merge": "^4.1.0",
"webpack-sources": "^1.0.0",
"zone.js": "^0.8.14"
},
"devDependencies": {
Expand Down
7 changes: 7 additions & 0 deletions packages/@angular/cli/models/webpack-configs/production.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ import { StaticAssetPlugin } from '../../plugins/static-asset';
import { GlobCopyWebpackPlugin } from '../../plugins/glob-copy-webpack-plugin';
import { WebpackConfigOptions } from '../webpack-config';

/**
* license-webpack-plugin has a peer dependency on webpack-sources, list it in a comment to
* let the dependency validator know it is used.
*
* require('webpack-sources')
*/


export function getProdConfig(wco: WebpackConfigOptions) {
const { projectRoot, buildOptions, appConfig } = wco;
Expand Down
1 change: 1 addition & 0 deletions packages/@angular/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"webpack-dev-middleware": "~1.12.0",
"webpack-dev-server": "~2.7.1",
"webpack-merge": "^4.1.0",
"webpack-sources": "^1.0.0",
"zone.js": "^0.8.14"
},
"optionalDependencies": {
Expand Down

0 comments on commit 2a3490f

Please sign in to comment.