-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with performance after upgrade from 0.2.8 to 1 #3370
Comments
I am experiencing the same and I have upgraded from 1.0.0-alpha.5 to 1.0.0-rc.1. Application bootstrap jumped from 1152ms to 2252ms. I have tested on latest Google Chrome on OSX. I have downgraded the version 1.0.0-beta.3 and it's fixing the issue and bootstrap time is around ~1000 ms. Please note that my application does a deep-link to a state depend on the user type on start up. /app/banking/investor/account/xxx/overview |
I'll look into this before next release. This perf regression is totally unacceptable. |
thanks @christopherthielen ! |
Closing in favor of #3361 |
@christopherthielen thanks for the confirmation. |
SO long story short, we made a big effort in our Angular 1.5+ app to upgrade to the 1.0 version of ui-router.( from 0.2.8 to 1.0.0-rc.1 ) Ever since the upgrade we have noticed terrible performance in our grids ( "angular-ui-grid": "3.0.7" )
After a week of performance testing (Chrome Dev Tools Timeline etc.), we were able to isolate one of the main issues as being from ui-router and the StateService.href function.
For example, in our datagrid, we create custom cell templates that just generate href routes to 'states' in the app. We use 'this.$state.href' (StateService.href) to do this.
There are a lot of cells in our grids that do this.
A quick example:
All browsers ( FF,IE,CHROME ) eventually freeze when we open up these grids. We tested by circumventing the ' this.$state.href' call and just hard coding href routes, and that made the performance MUCH better. The degradation of performance is so noticeable that we have discussed reverting back to the 0.2.8. , but I wanted to see if anyone else out there had also seen this and if you had any ideas on alternatives.
Thanks!
The text was updated successfully, but these errors were encountered: