Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 uiView inside conditional ngInclude causes "Cannot read property '$$animLeave' of undefined" #3004

Closed
shawnlan opened this issue Sep 16, 2016 · 5 comments

Comments

@shawnlan
Copy link

shawnlan commented Sep 16, 2016

Here is the test case: http://plnkr.co/edit/EuWGIKcyXCTY1vHiQXMj?p=preview

The error happens when:

  1. uiView inside a conditional ngInclude
  2. Switch ngInclude from On to Off and then back to On
  3. Go to a different root state

Any workaround before a fix?

Here is what I'm trying to do:

A not-logged-in user can go to any url, but he/she will see a login form. Once he/she logs in, he'll see that url's corresponded state view.

Should I go with a different approach? lazyLoad/future states that register after a user logs in? I'm not quite sure how that works.

@christopherthielen christopherthielen added this to the 1.0.0-final milestone Sep 17, 2016
@christopherthielen
Copy link
Contributor

Thanks for the bug report. This is definitely something we should support.

Targeting 1.0-final.

@christopherthielen
Copy link
Contributor

It was an off-by-one error. Fix should be coming tonight in beta.3

http://plnkr.co/edit/AELsuLBrGi73XTldkZgY?p=preview

@shawnlan
Copy link
Author

Nice. Thanks!

@abbymrs
Copy link

abbymrs commented Jul 28, 2017

@christopherthielen
Hi, I also got this error after i updated my application from angular version 1.5.0 to 1.6.5 with ui-router version 1.0.5.
It only happens with the sub-router with params, like "/demo/lists/:id", could you pls kindly give me some help?
Thanks a lot!

@hani647
Copy link

hani647 commented Aug 19, 2017

@christopherthielen
Same problem with me. In addition inside my ui-view container I can see 2 ui-view i.e.

<div ui-view>

    </div >

now when I call a state then I can see in my element inspector

<div ui-view>

    </div >
<div ui-view>

    </div >

Any help would be appreciated !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants