Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Remove url() from LocationService interface #2990

Merged

Conversation

wms
Copy link
Contributor

@wms wms commented Sep 13, 2016

  • LocationService.url() has been deprecated in favour of setUrl(),
    but this interface had not been fully updated.

- `LocationService.url()` has been deprecated in favour of `setUrl()`,
  but this interface had not been fully updated.
@wms wms force-pushed the remove-url-from-location-interface branch from 25932fe to 0d36639 Compare September 13, 2016 13:01
@wms wms changed the title fix(common): Remove LocationService.url fix(common): Remove url() from LocationService interface Sep 13, 2016
@christopherthielen
Copy link
Contributor

Huh, I thought .url() was still used as the read method, but apparently we're just using .path()

@christopherthielen christopherthielen added this to the 1.0.0-final milestone Sep 21, 2016
@christopherthielen christopherthielen merged commit d6c2580 into angular-ui:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants