Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url not changes when transition to new state complete (ng2) #2966

Closed
kolkov opened this issue Sep 3, 2016 · 1 comment
Closed

Url not changes when transition to new state complete (ng2) #2966

kolkov opened this issue Sep 3, 2016 · 1 comment

Comments

@kolkov
Copy link

kolkov commented Sep 3, 2016

router.stateService.target(public.user.login') not working
router.stateService.target('public.user.login', null, { source: 'unknown' }) working perfect!

#2964

@christopherthielen
Copy link
Contributor

  1. We track what triggers a transition (the trigger source). When triggered by a URL change, we don't update the URL.

  2. When we redirect a transition, we copy the .options() to the new Transition. I think this is copying the transition trigger as "url change"

  3. The initial transition was triggered by a URL change (the initial call to .sync()).

  4. I think the redirected transition options still has "url" as the source, but it should be something else like "redirect".

Here's where we create the redirected transition options: https://github.com/angular-ui/ui-router/blob/master/src/transition/transition.ts#L374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants