Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-alpha.1: $stateChangeStart and $stateChangeSuccess status #2655

Closed
hmdhk opened this issue Mar 29, 2016 · 4 comments
Closed

1.0.0-alpha.1: $stateChangeStart and $stateChangeSuccess status #2655

hmdhk opened this issue Mar 29, 2016 · 4 comments

Comments

@hmdhk
Copy link

hmdhk commented Mar 29, 2016

Hi,
What is the current status of $stateChangeStart and $stateChangeSuccess, they seem to be removed from the lib but I can't find any documentation about it.

What is the alternative solution if they're actually removed?

Thanks

@garycourt
Copy link

I just ran into this problem myself. Discovered you can use this instead:

$transitions.onStart({}, function() {});
$transitions.onSuccess({}, function() {});

@christopherthielen
Copy link
Contributor

Woops, it looks like 1.0.0-alpha.1 build didn't include the state events!

We've deprecated the $stateChange* events in favor of the $transitions lifecycle hooks. We do provide them as an addon file, however, which is missing in the release.

The hooks documentation is at http://angular-ui.github.io/ui-router/1.0.0-alpha.1/interfaces/transition.ihookregistry.html

@arcreative
Copy link

arcreative commented Mar 28, 2018

This was a pretty heinous thing to include without a deprecation notice. Just realized we have no analytics since the upgrade to 1.0, and pretty terrible migration help to get it back to where it needs to be. I vote greater caution is taken with this sort of stuff in the future, especially because removed events don't ever show up in your error tracking.

@christopherthielen
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants