New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-alpha0 exceptions during synchronous hook handlers don't reject the trans promise #2561

Closed

christopherthielen opened this issue Feb 17, 2016 · 0 comments

Labels

Milestone

Contributor

christopherthielen commented Feb 17, 2016

http://plnkr.co/edit/xGypfx132eNeBapLtSDQ -- nagivate to home.foo; it should throw an error, but then stay "no transition in progress..."

Fix goes here, i think: https://github.com/angular-ui/ui-router/blob/1.0.0alpha0/src/transition/transition.ts#L346

christopherthielen added bug 1.0 labels

christopherthielen added this to the 1.0.0-beta milestone

christopherthielen closed this as completed in

4b6d56f

christopherthielen modified the milestones: 1.0.0-beta, 1.0.0-alpha.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment