Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this backward compatibility of resolve function #2548

Closed
redhead opened this issue Feb 11, 2016 · 3 comments
Closed

this backward compatibility of resolve function #2548

redhead opened this issue Feb 11, 2016 · 3 comments
Labels

Comments

@redhead
Copy link

redhead commented Feb 11, 2016

In 0.2.x the resolve function is called with this pointing to the state it is transitioning to. In 1.0.0 alpha there is nothing. I don't know if this was intentional BC break because of new transition system, but I rather reported it for you to consider.

@nateabele
Copy link
Contributor

Added to the BC list, thanks for the report.

@ProLoser ProLoser changed the title this backward compatibility of resolve function this backward compatibility of resolve function Feb 11, 2016
@christopherthielen
Copy link
Contributor

I've been tossing around the idea of binding this to the path node object

@nateabele
Copy link
Contributor

Yeah, I was trying to think about what would be the most sensible in terms of the API (or nothing). That's an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants