Squash does not remove trailing slash in ui-sref

[ritenv]

If I define a state as below:

    $stateProvider.state('productsByCategory', {
        url: '/products/:catSlug/:subCatSlug?',
        controller: 'MyController',
        params: {subCatSlug: {value:null, squash: true}},
        templateUrl: '/app/products/list.html'
    })

I expect this to match the URL path /products/watches, which it does (no trailing slash).

However, if I do the below methods, I get the URLs with the trailing slashes:

    <a ui-sref="productsByCategory({catSlug: 'watches'})">Go to Watches</a>

I get the below compiled tag:

    <a ui-sref="/products/watches/">Go to Watches</a>

(The slash is not squashed)

Is this an expected behavior? And if so, is there a way to retrieve the squashed version via ui-sref?

[wesleycho]

Here is a reproduction - this appears to be a bug.

[adamreisnz]

+1

@nateabele this was flagged as a bug on October 2015, it doesn't seem like a very complicated thing to fix. Any chance someone could have a look at it?

[wesleycho]

You could always file a PR :)

[adamreisnz]

This seems to be related to (or the same as) #1902 which appears to have been fixed already in August last year, the changelog says version 0.2.16 (2016-01-24). However, it's not functioning anymore as it should in 0.3.0.

@wesleycho I've taken a look at the source code, and it seems this test is wrong as it has a trailing slash in the /users/: https://github.com/angular-ui/ui-router/blob/legacy/test/urlMatcherFactorySpec.js#L731

I've looked at the code in the urlMatcherFactory but the code is poorly documented and it would take me a while to figure out where all the data sits and how it all fits together. Someone with a better understanding of the internal workings of ui-router could probably spot the problem very quickly.

Is there anyone on the team with a couple of minutes to spare to have a look into this? It seems the issue has been addressed once before, so that would be a good starting point.

[stale]

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.