This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(modal): Switched the modal transclude to use $animate #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modal transclude now uses $animate.enter rather than element.append, this is so that the transcluded content can hook in the animation lifecycle. Also added unit tests for the uibModalTransclude directive as there were none before. Closes #6023
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal transclude switched to use $animate.enter rather than element.append, this is so that the transcluded content can hook in the animation lifecycle. Also added unit tests for the uibModalTransclude directive as there were none before.
Closes #6023