Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(tooltip): remove replace usage #5994

Closed

Conversation

wesleycho
Copy link
Contributor

  • Remove replace: true usage

BREAKING CHANGE: The template structure changed slightly due to the removal of replace: true - see documentation examples in action to see differences in practice.

This partially implements #5712.

@icfantv
Copy link
Contributor

icfantv commented Jun 13, 2016

We need to fully document this change in the release notes as this is going to break a lot of people's code (and upset a lot of people probably...). Also need to look at the demos and make sure nothing needs to be tweaked.

Should investigate having demos to show the users how to still get the functionality we've removed: is-open and placement. Hopefully, we don't have to explain popup-class.

- Remove `replace: true` usage

BREAKING CHANGE: The template structure changed slightly due to the removal of `replace: true` - see documentation examples in action to see differences in practice.
@wesleycho wesleycho force-pushed the feat/tooltip-popover-replace branch from 304f1f0 to 5733eb9 Compare June 13, 2016 19:55
@wesleycho
Copy link
Contributor Author

Looks like this survived without a docs update - nothing needs to be changed in the demo pages.

@icfantv
Copy link
Contributor

icfantv commented Jun 14, 2016

I was thinking that since we're removing core API features, we should give examples on how the user should be doing this on their own end. Otherwise, we'll be getting issues for "how do I...?" It would be nice to be able to point to something instead of just slapping them down w/ the standard issue forum use response. But I'm also in a benevolent mood at the moment. ;-)

@icfantv
Copy link
Contributor

icfantv commented Jul 4, 2016

LGTM

@wesleycho wesleycho closed this in 1616e97 Jul 19, 2016
@wesleycho wesleycho deleted the feat/tooltip-popover-replace branch July 19, 2016 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants