Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): add resolve values to template #5857

Closed

Conversation

wesleycho
Copy link
Contributor

  • Expose resolve in template as $resolve for those modals opened with a controller

This implements #5808, but may feature a minor breaking change - this could be fine to hold off until 2.0 if there are concerns about introducing a breaking change.

@deeg
Copy link
Contributor

deeg commented Apr 29, 2016

LGTM, after the rebase

@deeg
Copy link
Contributor

deeg commented Apr 29, 2016

Also @wesleycho, don't forget to add a BREAKING CHANGE comment to the body of the commit when merging.

@wesleycho wesleycho force-pushed the feat/resolve-in-template branch from f547ad6 to 350bfa5 Compare April 29, 2016 18:49
- Expose resolve in template as $resolve for those modals opened with a controller

BREAKING CHANGE: Since this adds support for $resolve being exposed on $scope, it could potentially overwrite any pre-existing usage of it - this is an unlikely scenario, but marked as a breaking change in case this key is being used
@wesleycho wesleycho force-pushed the feat/resolve-in-template branch from 350bfa5 to b38c4f4 Compare April 29, 2016 19:02
@wesleycho wesleycho added this to the 1.3.3 milestone Apr 29, 2016
@wesleycho wesleycho closed this in dd09148 Apr 29, 2016
@wesleycho wesleycho deleted the feat/resolve-in-template branch April 29, 2016 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants