This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(accordion): add data-uib-accordion-header support #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing uib-accordion-header directive to transclude data properly when it has the 'data-' prefix. Fixes angular-ui#5834
| @@ -124,7 +124,7 @@ angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse']) | |||
| link: function(scope, element, attrs, controller) { | |||
| scope.$watch(function() { return controller[attrs.uibAccordionTransclude]; }, function(heading) { | |||
| if (heading) { | |||
| var elem = angular.element(element[0].querySelector('[uib-accordion-header]')); | |||
| var elem = angular.element(element[0].querySelector('[uib-accordion-header], [data-uib-accordion-header]')); | |||
There was a problem hiding this comment.
Can you change it to support all of the selectors possible to be matched similar to how it works for the tabs? https://github.com/angular-ui/bootstrap/blob/master/src/tabs/tabs.js#L230-L236
There was a problem hiding this comment.
Yep, I can add them to the selector string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing uib-accordion-header directive to transclude data properly when the attribute has the 'data-' prefix.