Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(modal): body content shift #5711

Closed
wants to merge 1 commit into from
Closed

fix(modal): body content shift #5711

wants to merge 1 commit into from

Conversation

RobJacobs
Copy link
Contributor

Implements TWBS body padding fix to keep content in an element with a container class from shifting when the body overflow is set to hidden with the modal-open class.

Fixes #2631

@deeg
Copy link
Contributor

deeg commented Mar 30, 2016

Thanks for doing this! We might want to add some tests for the new logic in position service?

@RobJacobs
Copy link
Contributor Author

Tests are difficult when it comes to DOM interaction. You will notice most of the tests in the position module actually mock the DOM aspects (see offset test where it returns a mocked clientRect). I don't know if testing against mocked values really does anything for us?

@wesleycho
Copy link
Contributor

We need to eventually modify the build system to run tests via SauceLabs/Browserstack and run positioning tests across browsers.

- Implements TWBS body padding fix to keep content in an element
with a container class from shifting when the body overflow is
set to hidden with the modal-open class.

Fixes #2631
Closes #5711
@wesleycho
Copy link
Contributor

This LGTM

@deeg deeg closed this in c83d0a8 Mar 31, 2016
@RobJacobs RobJacobs deleted the modal-scrollbar branch March 31, 2016 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the background move a little when opening a modal.
3 participants