fix(modal): fix bindToController bug

[kuitos]

when set bindToController true,props not be bound to controller instance correctly before it initialize,this pointer not be init with $scope props

what I added in modal unit test

var $scope = $rootScope.$new(true);
$scope.foo = 'bar';
open({
  template: '<div>{{test.fromCtrl}} {{test.closeDismissPresent()}} {{test.foo}}</div>',
  controller: function($uibModalInstance) {
  + expect(this.foo).toEqual($scope.foo);
    this.fromCtrl = 'Content from ctrl';
    this.closeDismissPresent = function() {

it will make the test fail

Expected undefined to equal 'bar'.

because the props not bound to the this instance of controller correctly before the controller constructor called.

[wesleycho]

Why is bindToController being required here for $onInit usage?

[icfantv]

Per https://docs.angularjs.org/guide/component, in the Intercomponent Communication section, $onInit does NOT require bindToController being present.

[kuitos]

yes u are right,I had checked the source code of angular.js,it does not require controllerAs too.Pls review the latest commit.🙂