feat(tabs): Allow setting optional classes on each tab. #5430
Conversation
| @@ -34,16 +34,18 @@ describe('tabs', function() { | |||
| scope.first = '1'; | |||
| scope.second = '2'; | |||
| scope.actives = {}; | |||
| scope.classesFirst = "first-classes-1"; | |||
There was a problem hiding this comment.
Better named firstClass - also first-class-1, and use single quotes
|
This also needs documentation and demo updates. |
|
I fixed all reported issues. Any update on the status of this? Thanks. |
|
@amahfouz looks like you need to rebase first. |
wesleycho
added
needs: review
needs: rebasing
needs: squash
and removed
needs: squash
needs: work
labels
|
Needs squashing and rebasing (squash first). |
|
Thanks for the prompt reply. I had already done the squash. Now I did: git pull --rebase and did not get any conflicts, but there is nothing to push. What am I missing? |
|
git pull --rebase origin master |
|
Got it. Thanks. I have now squashed, rebased, and force pushed. Rerunning tests now. |
|
Tests now fail :( |
|
Checks now running. Let me know if I need to do anything else. |
| @@ -132,6 +133,10 @@ angular.module('ui.bootstrap.tabs', []) | |||
| }); | |||
| } | |||
|
|
|||
| if (attrs.classes === undefined) { | |||
There was a problem hiding this comment.
Do I need to fix this, resquash, rebase, etc. or this is within the margin of tolerance?
There was a problem hiding this comment.
Use angular.isUndefined here
|
This needs to be rebased. |
amahfouz
force-pushed
the
master
branch
3 times, most recently
from
f3125d7 to
6311881
Compare
|
I have made the last requested fix, squashed, and rebased. Please review. |
| @@ -143,6 +144,10 @@ angular.module('ui.bootstrap.tabs', []) | |||
| } | |||
| } | |||
|
|
|||
| if (angular.isUndefined(attrs.classes)) { | |||
| scope.classes = ""; | |||
|
Done. Squashed, rebased and pushed. |
* add breaking change note for 1.2.0 release for tab change in angular-ui#5430.
Allow setting any set of optional CSS classes on a uib-tab element.
This is to allow specifying classes such as "btn-sm" for tab pills.