Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

extra space next to the month selector #5392

Closed
kevinlbatchelor opened this issue Feb 2, 2016 · 11 comments
Closed

extra space next to the month selector #5392

kevinlbatchelor opened this issue Feb 2, 2016 · 11 comments

Comments

@kevinlbatchelor
Copy link

In chrome, there is extra space on the left side of the right arrow, next to the month selector.

@icfantv
Copy link
Contributor

icfantv commented Feb 2, 2016

I'm not seeing this on our demo page. Can you post a screenshot along with your code snippet?

@kevinlbatchelor
Copy link
Author

I'm just looking at your demo page, not my own code.

space

@icfantv
Copy link
Contributor

icfantv commented Feb 2, 2016

Oh. On the left side of the right arrow button. Thanks.

@icfantv
Copy link
Contributor

icfantv commented Feb 2, 2016

@wesleycho, I think this is a browser bug. Chrome is allocating an extra 2px to the <th> cell and the button widths are fine. We have no styling here and there's nothing I can see that we can do.

@RobJacobs
Copy link
Contributor

It's the pull-right class on the template here Year, Month, and Day templates all have the pull-right class on the right button.

@wesleycho
Copy link
Contributor

I think the fix for this should be

.uib-right {
  width: 100%;
}

Would need to test across browsers though.

@icfantv
Copy link
Contributor

icfantv commented Feb 2, 2016

That removes all the space entirely. Is that what we want?

@agrahamlincoln
Copy link
Contributor

.uib-right {
    width: 100%;
}

seems to fix it for all of the occurrences

Edit: @wesleycho 's solution is more simple but does the same thing

@icfantv
Copy link
Contributor

icfantv commented Feb 2, 2016

It needs to be

.uib-datepicker .uib-right, .uib-datepicker .uib-left {
  width: 100%;
}

or the spacing on the left won't match.

@agrahamlincoln
Copy link
Contributor

in that case, why not

.uib-left, .uib-right {
  width: 100%
}

Both CSS classes are only used in the template, I see no reason to complicate it

@wesleycho
Copy link
Contributor

I think the concern is if we ever use those classes for another component. I'm not hugely opinionated on which in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants