This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): Remove the $locationChangeSuccess close behaviour #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird, I checked that to be the problem on that issue and was negative for me. I tried this PR with the plunker and works: http://plnkr.co/edit/EF0uJQijkuBt3InRNkUW?p=preview Clearly I checked wrong. |
|
On the original Plunker, if you click the link, the popover will go away - this PR fixes it. It may have been an old hack to deal with some garbage collection issue that has since been fixed. |
|
yeah yeah, I checked if clicking on the new state would trigger that code and it didnt so I thought it wasn't the problem. Now with it gone, it works as expected. Weird but LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5337
Removed the code for handling location change, and removed the corresponding test.