This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): pass options from popup to inline #5355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass through options object wholesale from popup to inline datepicker BREAKING CHANGE: This breaks any snake-cased key usage, i.e. `show-weeks`. Convert all keys used to camelCase.
wesleycho
force-pushed
the
feat/datepicker-popup-options
branch
from
e2144cf to
d5f3f06
Compare
|
What is the reasoning of having datepickerMode in a separate way? |
|
The reason is because it is already optionally two-way bound in the inline datepicker as a separate attribute. Probably need to clean that up, but doing that now would be a slightly bigger change. I'm fine with making it - what do you think? |
|
What I don't see is how the inline datepicker picks that mode from how you put it here. |
|
It's mainly meant for reading |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This breaks any snake-cased key usage, i.e.
show-weeks. Convert all keys used to camelCase.