This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): use $locale for starting day #5281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the previous forEach need startingDay as well? And I would like a docs update. |
|
Forgot to remove that startingDay - good catch. |
wesleycho
force-pushed
the
feat/datepicker-locale
branch
3 times, most recently
from
e233d94 to
4d41d10
Compare
|
Works for me now. |
- Change to fallback to $locale.DATETIME_FORMATS.FIRSTDAYOFWEEK for first day column
wesleycho
force-pushed
the
feat/datepicker-locale
branch
from
4d41d10 to
5e4480d
Compare
|
Updated PR to make this a non-breaking change - please re-review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first day column
This implements #4954.