This repository has been archived by the owner on May 29, 2019. It is now read-only.
fixes TypeError: Cannot set property 'isOpen' of null #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes $evalAsync is fired when scope is null and I get error in console. This fixes that specificc situation
|
@RobJacobs is this possible when using $evalAsync? Seems strange to me...but not necessarily against this fix. Thoughts? |
|
@wesleycho I agree, would be nice to see a plunk reproducing the problem or a description of how this occurred. I'm not against the change but there may be a better approach. |
|
I'll merge this for now, and perhaps an investigation could be done to figure out what is happening here - this seems like a perpetual problem :( . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes $evalAsync is fired when scope is null and I get error in console. This fixes that specificc situation