Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

uib-collapse flicker issue. #5055

Closed
mehmetenes opened this issue Dec 11, 2015 · 2 comments
Closed

uib-collapse flicker issue. #5055

mehmetenes opened this issue Dec 11, 2015 · 2 comments

Comments

@mehmetenes
Copy link

After updating the ui-family libraries, the navigation menu based on collapse directive started to flicker at every load. Since my menu data is updated based on an interval, this caused flickers on regular basis. the old collapse directive was working without flickers. the issue is caused by the difference in expand and collapse methods called by the uibCollapse watcher.

the comment in the collapse method says;
// IMPORTANT: The height must be set before adding "collapsing" class.
// Otherwise, the browser attempts to animate from height 0 (in
// collapsing class) to the given height here.

it was taken into account in the old directive (collapse) but not in the new one and for those whose "shouldCollapse" is always false because of the newly resolved menu items will have a flicker effect during expand method call.

@icfantv
Copy link
Contributor

icfantv commented Dec 11, 2015

If you think you've found a bug, please follow these instructions.

@wesleycho
Copy link
Contributor

Closing due to lack of reproduction.

However, due to the nature of the last sentence, I suspect we already addressed this issue in #5075.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants