This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(paging): factor out common controller code #4968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I am not happy about is the tests. You refactorized it in different files but there is no |
|
Do we require tests with this change? All this is doing is technically exposing the lack of tests on the old UibPaginationController, since the tests in this library is behavioral in general. |
|
I hear you Wes. But I don't like to add new "components" without any kind of tests. I know that all we do is behavioral. So here we are pretending that the |
wesleycho
force-pushed
the
feat/paging-factory
branch
from
c1e4bb7 to
468ad84
Compare
|
Added tests |
wesleycho
force-pushed
the
feat/paging-factory
branch
3 times, most recently
from
7f67e64 to
5dedeae
Compare
| beforeEach(module('ui.bootstrap.paging')); | ||
| beforeEach(inject(function(_$rootScope_, uibPaging) { | ||
| $rootScope = _$rootScope_; | ||
| paging = uibPaging; |
There was a problem hiding this comment.
You're saving it for no reason.
- Create paging factory for creating common controller for the pagination and pager components
wesleycho
force-pushed
the
feat/paging-factory
branch
from
5dedeae to
46d4c45
Compare
|
It is good for me. I still need to sweep all of this, so I will do a second pass by then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pagination and pager components
This finishes off #4803.