This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(accordion): fix unexpected routing #4792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change anchor tag to `div` to prevent anchor tag from triggering route change BREAKING CHANGE: This causes the cursor style to be removed from the heading - implement CSS on the `accordion-toggle` class accordingly
wesleycho
force-pushed
the
fix/accordion-routing
branch
from
9e784c8 to
476e82a
Compare
|
Would a inline style on the div (for the cursor) be too much? In ng2 it is way better. |
|
We could do it, but I think I rather it be captured in user CSS - less overhead in overriding there. |
|
that makes sense too. I am ok with both. |
|
Any time frame for the next release? Just spent a few hours trying to debug my app only to figure out it was related to this. |
|
One can override the template locally for now to work around this. As far as when it will be released, we're hoping for the end of the year - other than that, we can't say yet except to keep your eyes open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
divto prevent anchor tag from triggering route changeBREAKING CHANGE: This causes the cursor style to be removed from the heading - implement CSS on the
accordion-toggleclass accordinglyThis fixes #4533.