Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

collapsing navbar issue #4628

Closed
kukac7 opened this issue Oct 15, 2015 · 9 comments
Closed

collapsing navbar issue #4628

kukac7 opened this issue Oct 15, 2015 · 9 comments

Comments

@kukac7
Copy link
Contributor

kukac7 commented Oct 15, 2015

hi,

i noticed one interesting the collapse navbar.

http://embed.plnkr.co/FQWDqyFnDonUJdv1bPpr/preview
(latest bootstrap, angular-ui bootstrap, angularjs)

http://embed.plnkr.co/XVxhkRkSYPb1E8Tz6PDu/preview
(latest bootstrap, angularjs, angular-ui bootstrap 0.13.4)

in-and-out closing update navbar-collapse class: collapsing (latest angular-ui bootstrap)
in-and-out closing update navbar-collapse class: collapse (angular-ui bootstrap 0.13.4)

above the navbar 768px height has 0px in inline style.
the collapsing class does not work over 768px.
something is not right.

thanks for the help!

@Foxandxss
Copy link
Contributor

I can see something fishy happening, probably made in 533a9f0

@kukac7
Copy link
Contributor Author

kukac7 commented Oct 16, 2015

@Foxandxss i think the problem is with class.

@Foxandxss
Copy link
Contributor

You could try a PR if you want. That would be highly appreciated.

@kukac7
Copy link
Contributor Author

kukac7 commented Oct 18, 2015

i tested and i think the problem you have if you do not ngAnimate include.
i think it's something that should be checked.
the $animate still object.

i personally do not usually use ngAnimate, so it would be a good solution. 😃

thank you!

@Foxandxss
Copy link
Contributor

Don't worry mate. I just fixed this issue. I will create a PR and it will be there for the next version.

@Foxandxss
Copy link
Contributor

Or I think I had. Now I get a weird behavior with animate, grrr.

@kukac7
Copy link
Contributor Author

kukac7 commented Oct 18, 2015

@Foxandxss thank you for your help and the rapid response.
i see there is not much good solution. 😔

@Foxandxss
Copy link
Contributor

Nah, don't worry. It is fixed, you will need to use 1.4.5 or more. We expect to release this week.

@kukac7
Copy link
Contributor Author

kukac7 commented Oct 18, 2015

@Foxandxss ok, thanks! 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants