This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(timepicker): add accessibility improvements #4573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,3 +50,7 @@ All settings can be provided as attributes in the `<uib-timepicker>` or globally | |||
| * `max` | |||
| _(Defaults: undefined)_ : | |||
| Maximum time a user can select | |||
|
|
|||
| * `timepicker-tabindex` | |||
There was a problem hiding this comment.
couldn't we use tabindex here? And remove it from the timepicker host element if needed?
There was a problem hiding this comment.
I thought about it, but I had a concern...but I can't remember it now - I am willing to go that route though for simplicity.
wesleycho
force-pushed
the
feat/timepicker-accessibility
branch
2 times, most recently
from
445f358 to
a6cdd6e
Compare
- Add ng-disabled usage in template - Add `timepickerTabindex` attribute support for binding tabindex to timepicker controls
wesleycho
force-pushed
the
feat/timepicker-accessibility
branch
from
a6cdd6e to
e0e5d71
Compare
|
Not really my topic. The only bit to talk here is that we shouldn't be supporting the deprecated directives. The point is to force people to upgrade and not fixing them is a good way to do so. |
|
This has nothing to do with deprecated directive support :) . |
|
I know I know, I just said that tabs and accessibility is not something I can talk about. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4569