This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(tooltip): add uib- prefix #4515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
feat/tooltip-popover-rename
branch
from
48b2f4b to
c829bc6
Compare
| $log.warn('popover-template is now deprecated. Use uib-popover-template instead.'); | ||
| } | ||
|
|
||
| return $tooltip('popoverTemplate', 'popover', 'click', { |
There was a problem hiding this comment.
I think I would make this use the new tooltip.
There was a problem hiding this comment.
This is the old popoverTemplate directive
|
Check my Modal PR to see how I managed to get all the deprecation messages out in tests.(you have lots of directives but few deprecation message tests). |
|
I think I just forgot to write the other tests |
wesleycho
force-pushed
the
feat/tooltip-popover-rename
branch
from
c829bc6 to
90808ef
Compare
|
This PR should be good to review again. |
|
Missing doc updates, but I fixed that for you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does it for the tooltip and popover (couldn't get both in the commit message due to conventional-changelog).