Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(progress): re-calculate percentage when a bar is removed or altered #4471

Closed
wants to merge 1 commit into from
Closed

fix(progress): re-calculate percentage when a bar is removed or altered #4471

wants to merge 1 commit into from

Conversation

JDeuker
Copy link
Contributor

@JDeuker JDeuker commented Sep 25, 2015

See: #4452

@pkozlowski-opensource
Copy link
Member

@JDeuker thnx for the PR. It will need a test(s) before merging, though. Also, could you please change the commit message to follow our convention. Ex.: fix(progress): re-calculate percentage when a bar is removed or something along those lines.

@JDeuker JDeuker changed the title ProgressController recalculatePercentage bugfix fix(progress): re-calculate percentage when a bar is removed or altered Sep 25, 2015
@wesleycho wesleycho mentioned this pull request Oct 11, 2015
Closed
@wesleycho wesleycho closed this in feb689c Oct 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: progressbar needs: PR test(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDeuker @pkozlowski-opensource