This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): disable today button if invalid #4199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable today button if current date is before `min-date` or after `max-date`
wesleycho
force-pushed
the
feat/datepicker-disable-today
branch
from
1f39227 to
0a42b70
Compare
|
I see the code, but I don't see it working on the plunker. I toggle the minDate but "today" can be clicked. In this type of plunker (where you have lot of buttons and widgets, could be good if you add some instructions at the top of the plunker to reproduce it. I am probably clicking the wrong buttons I guess. |
|
minDate is already toggled by default - toggling the button disables the minDate. |
|
But if I click another date and I click today, it moves. Shouldn't it be disabled? |
|
I'm not seeing that behavior - the today button should only be enabled (in the popup mind you) if minDate is enabled in my example. I updated it to strip out any distractors. |
|
Ah, I was checking the other today button with the inline calendar. 👍 for me then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min-dateor aftermax-dateThis can be seen in action here.
This resolves #3988.