Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Carousel broken with Angular 1.4.3 + UI-Bootstrap 0.13.2 + ng-animate + modal dialog #4119

Closed
alpeshgaglani opened this issue Aug 5, 2015 · 4 comments

Comments

@alpeshgaglani
Copy link

I'm aware of the issue #3811 , and have the latest fixes from master. The carousel works just fine outside of a dialog box. However, when I use ngAnimate inside a $modal dialog, I see just the first slide. The navigation anchors are hidden, and I cant move to the second slide. Any ideas?

@wesleycho
Copy link
Contributor

Looks like you are correct to a degree, I am able to reproduce here incorrect behavior of a different nature.

@wesleycho
Copy link
Contributor

Ah, now I see the behavior you describe (Plunker was behaving weird for me there).

@wesleycho wesleycho self-assigned this Aug 6, 2015
@wesleycho
Copy link
Contributor

Investigating this, this appears to be a problem with the modal service, and it not being converted to handle $animateCss support. There seems to be some interplay problems between the two due to the new restrictions in ngAnimate.

@wesleycho
Copy link
Contributor

This should be fixed in master now - thanks a lot for this find, I almost cut a new release today before encountering this issue (& the tooltip/popover one).

I highly recommend checking out the comments in #4121, it is highly relevant if you're living on the edge :) .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants