This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(typeahead): add support for ngModelOptions getterSetter #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me! Thank you. :) |
|
This fixes the problem for me as well. Please merge this for 0.13.1. Thanks! |
- Add support for getterSetter with ngModelOptions
wesleycho
force-pushed
the
fix/typeahead-getter-setter
branch
from
7c27760 to
963ec0e
Compare
|
Argh, this feels like we're copying internal ngModel APIs to be able to replicate its functionality. Is there no other alternative? |
|
I don't like it either, but upon inspecting how ng-model implements it, this seems like how we have to do it - ideally the typeahead probably should be refactored since the whole $setModelValue is a bit of a hack. |
|
After discussing this a bit with some others on this, the opinion is that this is an ok change - IMO this is a weakness with the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix can be seen in action in this Plunker.
This fixes #3823.