This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(pagination): paging buttons stay focused when page is changed #3486 #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t doesn't stay focused after the page changes.
|
Hi @benthepoet, could you add some tests for this? |
-tested page link -tested direction links -tested boundary links -tested page link when max-size is set
wesleycho
added
needs: info
needs: review
and removed
needs: PR test(s)
needs: info
labels
| if ( $scope.page !== page && page > 0 && page <= $scope.totalPages) { | ||
| if (evt && evt.target) { |
There was a problem hiding this comment.
Will this ever be called without an event object?
There was a problem hiding this comment.
Yes, below is the only spot where it gets called without an event.
|
Thanks for this work - this will make it in the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3486. Just needed to pass in the $event to blur the page button after it has been clicked. Page numbers were sticking upon selection because "track by $index" with ngRepeat keeps the DOM from destroying and recreating elements most of the time. Direction links were also affected along with pager template as well.