Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Accordion should not transclude content into div.panel-body #3387

Closed
andreialecu opened this issue Mar 14, 2015 · 6 comments
Closed

Accordion should not transclude content into div.panel-body #3387

andreialecu opened this issue Mar 14, 2015 · 6 comments

Comments

@andreialecu
Copy link
Contributor

There are various use cases when using the accordion where one may not want all contents transcluded into a div with class panel-body.

For example, I want to use a panel footer and a list group as per: http://getbootstrap.com/components/#panels

This is currently not possible, because all content is trapped into a div.panel-body as defined in the accordion-group.html template.

I'm ready to submit a PR for this, but I'm not sure how to keep it backwards compatible. Perhaps an attribute like <accordion-group auto-panel-body="false" ...

@Foxandxss
Copy link
Contributor

Yo!

I am gonna check it in a future, we need to bring this back to life and this is not an important issue right now. You can always override the template for that use case. Will leave this open tho :)

@karianna karianna added this to the Backlog milestone Mar 16, 2015
@XmlmXmlmX
Copy link

In case of tables inside panels it is also a problem.
http://getbootstrap.com/components/#panels-tables

@rvanbaalen
Copy link
Contributor

I would say creating your own accordion template for that use case is the way to go..

@wesleycho
Copy link
Contributor

Creating a custom template may be a bit awkward, but at the least, there is now the ability to use a custom template on a component by component basis for the accordion due to #4084, which should ease the problem a bit.

This may require a bit of investigation.

@Foxandxss
Copy link
Contributor

This could be done with a custom template since it is something to be done in userland.

@ravigithub
Copy link

i think it'll make an custom accordion as it was showed in the bootstrap in it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants