Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

performance issue with ui.bootstrap.collapse - fixUpHeight function #121

Closed
cocodrino opened this issue Feb 6, 2013 · 2 comments
Closed

Comments

@cocodrino
Copy link

sorry for this really noob question but:..I'm learning angularjs and my first "dummy app" is a feed reader, really simple using the google reader api, I load the feeds from a source inside an accordion, this works really fine for the first source than I click...but in the next sources I get a big performance issue...I did a javascript profile first (next are the memory issues :D ) and this shows than fixUpHeight consumes 43.49% of the time...that is a lot and this function seems be a little "tricky"...do you how could I fix this and keep using the accordion element (I like it a lot)....

@ajoslin
Copy link
Contributor

ajoslin commented Feb 6, 2013

Hi cocodrino! Thanks for stopping by.

Do you think you would be able to provide us a minimal use case of this happening in a running example? You can start with http://plnkr.co/edit/uOlLL0?p=preview

Also, what browser were you in when this started happening?

And you're right, the fixUpHeight function is quite "tricky"!

@cocodrino
Copy link
Author

Hi Andy, I fix the issue removing the accordion between calls using ui-if, so this not need resize between calls, also I did a small change in the angularjs core following this angular/angular.js#1627 I had this issue too but now this works really smooth...very nice!!:..thanks...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants