You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
This is not quite related to the asynchronous loading issue (I've seen #1188).
All the templateUrls are hard-coded to something like "template/progressbar/progress.html". This means that my template directory is filled with templates for Bootstrap components. It also means that the templateUrl template/(component) is taken for each of the components.
Unless I'm missing something, it would be friendlier to other code to put all the templates in template/bootstrap/*.
This would be a breaking change, but Bootstrap 3.0 support is going to break backwards compatibility soon anyway.
The text was updated successfully, but these errors were encountered:
From #1188, I can put the templates wherever I want. But the angular template cache will have the Angular Bootstrap template cached as template/alert/alert.html. Essentially, the problem is that this bleeds into other namespaces. What if I already have a module called alert with a template at template/alert/alert.html? What if I want to include another library that wants a template there?
@webarnes we need to put those templates somewhere in the $templateCache so there will be always risk of collisions... But adding library name is not a bad idea, I think it makes sense. Can be done as part of BS3 migration, not the top priority, though.
@pkozlowski-opensource I agree. Also, since we are encouraging build-time template path configuration and discouraging XHR loading of templates, perhaps we can use $templateCache a little more arbitrarily. Instead of templates/alert/alert.html we could just do angular-bootstrap-alert.tpl.html, which would be an easy transformation in grunt. Since the path in $templateCache doesn't matter and since we would be doing what we're asking users to do when they change the paths, it may make answering some of those queries easier; we would just say "take a look at our Gruntfile".
This is not quite related to the asynchronous loading issue (I've seen #1188).
All the templateUrls are hard-coded to something like "template/progressbar/progress.html". This means that my template directory is filled with templates for Bootstrap components. It also means that the templateUrl template/(component) is taken for each of the components.
Unless I'm missing something, it would be friendlier to other code to put all the templates in template/bootstrap/*.
This would be a breaking change, but Bootstrap 3.0 support is going to break backwards compatibility soon anyway.
The text was updated successfully, but these errors were encountered: