Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
feat(alert): pass $event to close()
Browse files Browse the repository at this point in the history
Add ability to hook into `$event` in close callback

Closes #3828
Fixes #3827
  • Loading branch information
Avi Cherry authored and wesleycho committed Jun 26, 2015
1 parent 36e0f0e commit 44e0642
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion template/alert/alert.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="alert" ng-class="['alert-' + (type || 'warning'), closeable ? 'alert-dismissible' : null]" role="alert">
<button ng-show="closeable" type="button" class="close" ng-click="close()">
<button ng-show="closeable" type="button" class="close" ng-click="close($event)">
<span aria-hidden="true">&times;</span>
<span class="sr-only">Close</span>
</button>
Expand Down

1 comment on commit 44e0642

@ymkins
Copy link

@ymkins ymkins commented on 44e0642 Sep 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It brakes the close callback in controllerAs syntax:
http://plnkr.co/edit/5UIOVj3sDYIyUoNScql9

Issue filled #4386

Please sign in to comment.