Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 5+ #20

Open
1 of 3 tasks
lvidal1 opened this issue Nov 11, 2017 · 6 comments
Open
1 of 3 tasks

Support for Angular 5+ #20

lvidal1 opened this issue Nov 11, 2017 · 6 comments

Comments

@lvidal1
Copy link

lvidal1 commented Nov 11, 2017

This is a...

  • feature request
  • bug report
  • usage question

Additional Notes:

Currently this project does not support Angular 5.0.
Is there any pre-release that does?

What do we need to change to implement the support?

@yohannpoli
Copy link

Any news on that issue? Thanks in advance.

barretodavid added a commit to barretodavid/router that referenced this issue Nov 29, 2017
e-schultz pushed a commit that referenced this issue Nov 29, 2017
@yohannpoli
Copy link

yohannpoli commented Nov 29, 2017

Can you please reopen that issue?

Installing the 6.4.0 generate a directory structure has lib/**src**/es5 while the package is defined with "main": "./lib/es5/index.js",

Result: "Cannot find module @angular-redux/router"

@e-schultz
Copy link
Member

@yohannpoli @Bil0 - just published 6.4.1 that should fix this

@Bil0
Copy link

Bil0 commented Nov 29, 2017

Back to compiler 4 solve the problem, but it would be nice to upgrade to angular 5 compiler and rxjs 5.5.2 (like @angular-redux/store) in the future.
Thanks!

@e-schultz
Copy link
Member

@Bil0 Just published v7 - let me know if you have any issues

@e-schultz e-schultz reopened this Nov 30, 2017
@skiraikou
Copy link

Guys readme should be updated?
As i see NgReduxRouterModule should be NgReduxRouterModule.forRoot()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants