fix(endpoint:controller): wrap saveUpdates in an if(entity) statement #2059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #2052
Fixes issue in endpoint controller - when
handleEntityNotFound
returnsnull
if the entity is not found, it causessaveUpdates
to throw an error since updated.save() is called on null. This will result in a 500 response when the entity is not found, instead of the expected 404.Wrapping
saveUpdates
inif(entity)
will make it return withundefined
when the entity isnull
, which solves the issue.