Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix templateCache generation on gulpfile (#1936) #1942

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

ingoncalves
Copy link
Contributor

Change execution order for gulp tasks 'transpile:client' and 'html' to fix the templateCache generation.

closes #1936

@Awk34
Copy link
Member

Awk34 commented May 31, 2016

Hmm, This fix seems strange. We don't want the html task to be directly dependent on the transpile:client task. How about instead you add transpile:client in the build task, before build:client gets run?

@ingoncalves
Copy link
Contributor Author

like this?

gulp.task('build', cb => {
    runSequence(
        [
            'clean:dist',
            'clean:tmp'
        ],
        'jade',
        'inject',
        'wiredep:client',
        'transpile:client',
        [
            'build:images',
            'copy:extras',
            'copy:fonts',
            'copy:assets',
            'copy:server',
            'transpile:server',
            'build:client'
        ],
        cb);
});

it works for me!

@Awk34
Copy link
Member

Awk34 commented May 31, 2016

@ingoncalves precisely

@ingoncalves
Copy link
Contributor Author

ingoncalves commented May 31, 2016

it looks more beautiful

gulp.task('build', cb => {
    runSequence(
        [
            'clean:dist',
            'clean:tmp'
        ],
        'jade',
        'inject',
        'wiredep:client',
        [
          'transpile:client',
          'transpile:server'
        ],
        [
            'build:images',
            'copy:extras',
            'copy:fonts',
            'copy:assets',
            'copy:server',
            'build:client'
        ],
        cb);
});

…ck#1936)

Change execution order for gulp tasks 'transpile:client' and 'html' to fix the templateCache generation.

closes angular-fullstack#1936
@Awk34 Awk34 merged commit 0286817 into angular-fullstack:master Jun 1, 2016
@ingoncalves ingoncalves deleted the fix-1936 branch June 1, 2016 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular-fullstack generator failed to load template while running dist folder
2 participants