fix stylus includes #1609
Closed
fix stylus includes #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
studentIvan
commented
Feb 4, 2016
studentIvan
commented
- fix stylus extension (from .stylus to .styl)
- fix default stylus includes in app.styl (account/login/login contains nothing and it does produce some err)
| @@ -45,7 +45,6 @@ | |||
| <% } %> | |||
| // Component styles are injected through grunt | |||
| // injector | |||
| @import "account/login/login" | |||
There was a problem hiding this comment.
this file doesn't exists
There was a problem hiding this comment.
Oh you're right, curious, it used to exist. Anyway, if you're going to remove this, it should be in a separate commit, and you should do the same change for the SCSS and LESS files.
|
Thanks. I've pulled out the app.styl change and merged the rest. |
Awk34
pushed a commit
that referenced
this pull request
Feb 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.