-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): publicly expose utils related to eslint-plugin #676
Conversation
Nx Cloud ReportCI ran the following commands for commit 4ff6ca8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 85.89% 85.60% -0.29%
==========================================
Files 89 83 -6
Lines 2502 1924 -578
Branches 444 337 -107
==========================================
- Hits 2149 1647 -502
+ Misses 207 168 -39
+ Partials 146 109 -37
|
Nice! I'll try to take a look at this later today or tomorrow to see what could be improved (mainly making things more flexible since they were created for this specific project) to take advantage of the v13 migration window. |
FYI @rafaelss95 this is a significant internal refactor. The utils package going beyond testing utils happened sooner than I thought 😁
I'm fortunate to be dogfooding this at work right now writing some workspace specific lint rules using these utils.
We obviously have v13 coming up too so we can always make some breaking changes to these groupings and import paths if we need to.
I will be following up with a similar PR for the template related utils