Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): publicly expose utils related to eslint-plugin #676

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Sep 9, 2021

FYI @rafaelss95 this is a significant internal refactor. The utils package going beyond testing utils happened sooner than I thought 😁

I'm fortunate to be dogfooding this at work right now writing some workspace specific lint rules using these utils.

We obviously have v13 coming up too so we can always make some breaking changes to these groupings and import paths if we need to.

I will be following up with a similar PR for the template related utils

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #676 (4ff6ca8) into master (34e5523) will decrease coverage by 0.28%.
The diff coverage is 98.46%.

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   85.89%   85.60%   -0.29%     
==========================================
  Files          89       83       -6     
  Lines        2502     1924     -578     
  Branches      444      337     -107     
==========================================
- Hits         2149     1647     -502     
+ Misses        207      168      -39     
+ Partials      146      109      -37     
Impacted Files Coverage Δ
...nt-plugin/src/rules/no-inputs-metadata-property.ts 100.00% <ø> (ø)
...t-plugin/src/rules/no-outputs-metadata-property.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-pipe-impure.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/prefer-output-readonly.ts 100.00% <ø> (ø)
...t-plugin/src/rules/use-pipe-transform-interface.ts 91.66% <ø> (ø)
...es/eslint-plugin/src/rules/contextual-decorator.ts 72.00% <33.33%> (ø)
.../eslint-plugin/src/rules/component-class-suffix.ts 92.85% <100.00%> (-0.48%) ⬇️
...gin/src/rules/component-max-inline-declarations.ts 80.00% <100.00%> (-0.56%) ⬇️
...ages/eslint-plugin/src/rules/component-selector.ts 88.23% <100.00%> (-0.66%) ⬇️
...es/eslint-plugin/src/rules/contextual-lifecycle.ts 95.23% <100.00%> (-0.22%) ⬇️
... and 44 more

@JamesHenry JamesHenry merged commit 07711f1 into master Sep 9, 2021
@JamesHenry JamesHenry deleted the expose-eslint-plugin-utils branch September 9, 2021 16:57
@rafaelss95
Copy link
Member

Nice! I'll try to take a look at this later today or tomorrow to see what could be improved (mainly making things more flexible since they were created for this specific project) to take advantage of the v13 migration window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants