Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect store hook #24

Merged
merged 30 commits into from
Aug 28, 2019
Merged

Connect store hook #24

merged 30 commits into from
Aug 28, 2019

Conversation

aneurysmjs
Copy link
Owner

No description provided.

@aneurysmjs aneurysmjs self-assigned this Aug 20, 2019
use renderWithRedux utility function
remove the use of raw <Provider store={...} /> since it's already been handled
…roperty

create ASYNC_ACTION_TYPE constant and use it as 'type' for async actions to prevent that error, the
test fails anyways but at least is for other reasons

fix #24
install 'redux-mock-store' to check all the actions that have been made to the store and assert each
request's step

fix #26
…d-middlewares

Issue/26/test async actions and middlewares
extract getProducts selector from products reducer and fix paths where is been used

fix #24
just for the meantime while I'm figuring out how to test PROPERLY using react-redux's hooks

fix #24
improve Product's typing by extending it with Base type

fix #24
@aneurysmjs aneurysmjs merged commit 093029f into master Aug 28, 2019
@aneurysmjs aneurysmjs deleted the connect-store-hook branch August 28, 2019 04:59
@aneurysmjs
Copy link
Owner Author

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant