Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared dictionary support? #38

Open
espoal opened this issue Oct 7, 2022 · 4 comments
Open

Shared dictionary support? #38

espoal opened this issue Oct 7, 2022 · 4 comments

Comments

@espoal
Copy link

espoal commented Oct 7, 2022

In theory google/brotli has support for shared dictionaries. In practice I've not seen any example anywhere.

Does this package support shared dictionaries? Could you maybe provide an example?

@andybalholm
Copy link
Owner

Brotli uses a pre-defined static dictionary. I don't think there is any support for using user-generated dictionaries like zstd does.

@andybalholm
Copy link
Owner

Oh, now I see that a shared dictionary feature was added a while back. My Go version of the library doesn't have any support for it.

@espoal
Copy link
Author

espoal commented Oct 7, 2022

Is there any plan to add support? If I understand correctly, this project is generated via c2go so in theory it should be possible to add (automatically?) the API needed.

Or maybe you tell me there's a lot of legwork to do?

@andybalholm
Copy link
Owner

It was generated with c2go, but changes have been made since. We can't just regenerate it from the C version now. I don't have any plans to add it, but pull requests are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants