Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action terminates successfully despite failure #58

Open
katexochen opened this issue Sep 7, 2021 · 2 comments
Open

Action terminates successfully despite failure #58

katexochen opened this issue Sep 7, 2021 · 2 comments

Comments

@katexochen
Copy link

I was using the copycat action with the wrong token, that didn't had needed rights. The copying failed (file wasn't copied to the other repo), but the action terminated successfully. I would have expected the action to fail if the token hasn't got the rights needed.
I don't know if this is a bug, just wanted to leave this here, feel free to close this issue if this isn't of interest for you.

copycat-issue

@greybax
Copy link

greybax commented Sep 21, 2021

@katexochen I've faced with similar issue and got answer in this PR https://github.com/andstor/copycat-action/pull/49/files

@katexochen
Copy link
Author

Thanks for your answer, @greybax. I didn't opened this issue because I couldn't get my workflow running, but because I think the action should terminate with an error if the action hasn't got the needed rights. What it does right now is saying "Copying Complete 👌", what is obviously wrong, and returning with an exitcode of 0, which will show on GitHub that the action run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants