Bugfix: segment_duration and media_time use different units #1792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ISO 14496-12, section 8.6.6.3,
segment_duration is based on timescale in movie header box(mdhd)
media_time is based on timescale track header/media timescale
So segment_duration and media_time use different units.
The implementation in other Media3 codes/AOSP are correct, such as
(1) BoxParser.java line 712, 714, 716--718 and 731: https://github.com/androidx/media/blob/main/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/BoxParser.java#L712
(2) On AOSP https://cs.android.com/android/platform/superproject/main/+/main:frameworks/av/media/module/extractors/mp4/MPEG4Extractor.cpp;l=583