Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo apps for Audio Streams (ie Radios) show a picture instead of black screen #1234

Closed
pooya-mohammadhossein opened this issue Mar 31, 2024 · 3 comments
Assignees

Comments

@pooya-mohammadhossein
Copy link

Hi there,

First of all, keep up the great work on [Media3]!

This is a minor suggestion, and it's easy to implement in the demo apps. I propose adding an image (like a banner) when using Media3's audio stream instead of displaying a black screen. This visual cue would help ordinary users understand that the audio is playing even though they see a black screen, making the Media3 demo apps more visually appealing.

To reproduce the issue, simply try using any audio stream with a demo app, such as this one:

https://sarcheshmeh2-ssl.icdndhcp.com/stream

With the latest Media3 1.3.0 demo apps, you'll see a black screen while the audio plays in the background.

Thanks in advance for considering this suggestion!
Pooya

@pooya-mohammadhossein
Copy link
Author

pooya-mohammadhossein commented Apr 1, 2024

Just to give you some hint, it seems although usesCleartextTraffic has been set in Application mode, but it won't apple to MP3 URL http. especially when Mp3 http is redirected.
Cheers!
Pooya M

@rohitjoins
Copy link
Contributor

Hi @pooya-mohammadhossein,

Banners are typically used to provide additional information or context about media content. If the media doesn't inherently include this information, adding a banner could confuse users or misrepresent the content.

The primary goal for demo apps in Media3 is to provide common use cases, which serves as starting point for developers to integrate the library into their own app. Please feel free to add your customizations as you see fit.

@rohitjoins rohitjoins self-assigned this Apr 4, 2024
@rohitjoins rohitjoins closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@pooya-mohammadhossein
Copy link
Author

@rohitjoins I have achieved to fix this issue myself on my App. I have unsubscribed from this page. bye for now. Thanks though!
Cheers!
Pooya!

@androidx androidx locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants